- π§π¬Bulgaria pfrenssen Sofia
The patch in #5 adds unrelated coding standards and documentation fixes. The patch in the MR looks good but adds a whitespace error.
- Status changed to Needs work
over 1 year ago 1:16pm 1 September 2023 - π§π¬Bulgaria pfrenssen Sofia
Since this breaks backwards compatibility with Charts 3.2 and below, we should declare version compatibility in composer and the module info file.
We should probably create a new major 3.0.0 release or minor 2.1.0 release when this gets merged.
- Status changed to Needs review
over 1 year ago 1:58pm 1 September 2023 - π§π¬Bulgaria pfrenssen Sofia
Updated the MR with my remarks. Since this now changes the module's info.yml, the patch from the MR will probably not apply against the packaged releases from Drupal.org since they append version info to the file. It's easy to work around this by requiring the dev branch:
"require": { "cweagans/composer-patches": "^1.6.5", "drupal/charts_field_formatter": "2.0.x-dev" }, "extra": { "patches": { "drupal/charts_field_formatter": { "Patch for 3.3 compatibility https://www.drupal.org/project/charts_field_formatter/issues/3249136": "https://git.drupalcode.org/project/cha rts_field_formatter/-/merge_requests/2.diff" } } }
- πΊπΈUnited States NicholasS
Been running this patch for over 2 years, so I would say this has been reviewed.
- πΊπΈUnited States NicholasS
Adding a patch for d10
{ "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/charts_field_formatter" ] }, { "type": "vcs", "url": "https://git.drupalcode.org/issue/charts_field_formatter-3369229.git" },
"drupal/charts": "^3.5", "drupal/charts_field_formatter": "dev-3369229-automated-drupal-10-charts-3.3",
patches
"drupal/charts_field_formatter": { "Patch to allow any chart option to be overwritten": "https://git.drupalcode.org/project/charts_field_formatter/-/merge_requests/1.diff" },
- Status changed to Closed: outdated
8 months ago 9:12am 17 April 2024