Contrib.social

Toolbar Icons Setting Has No Effect

Open on Drupal.org →
Created on 12 November 2021, over 3 years ago
Updated 4 February 2024, about 1 year ago

Problem/Motivation

As part of preparing to upgrading to Drupal 9, I am using drupal/simplemde:1.0.0-alpha4 and ionaru/easy-markdown-editor:2.15.0 with the 9a55ddf revision of the dev-3103679-8.x-2.x issue fork of Markdown and league/commonmark:1.6.6. With this combination of plugins, no matter what toolbar icons are chosen for a text format that is using EasyMDE, the settings have no effect on what toolbar icons actually appear.

Steps to reproduce

  1. Install the noted versions of the various Markdown-related modules.
  2. Edit (or create) a text format under /admin/config/content/formats.
  3. Select "EasyMDE" as the "Text editor".
  4. Under "Available buttons", uncheck all options except "Code" and "Markdown guide".
  5. Save the text format.
  6. Edit a node or piece of content that uses the new/edited text format.
  7. Examine what buttons are in the toolbar.

Proposed resolution

It looks like EasyMDE expects to receive the names of the buttons that should be shown in the showIcons setting key and the names of the buttons that should be hidden in the hideIcons setting key, but it's receiving the showIcons key as an object, where the key is the name of the icon and the value is a boolean. This needs fixing.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Component

Code

Created by

🇺🇸United States GuyPaddock

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024