Use data-uk-xxx instead of uk-xxx attributes

Created on 6 November 2021, about 3 years ago
Updated 12 August 2023, over 1 year ago

Hello maintainers,

Problem/Motivation

With UIkit, we use many attributes as uk-grid or uk-nav...
The framework allows 2 syntax for that : uk-grid or data-uk-grid
The uk-xxx way generate errors with validators as W3C , while data- attributes are valid in HTML 5.

Moreover, data-uk-xxx way is more legible (less confusion with the framework classes) and the only method supported with React.

Proposed resolution

Replace uk-xxx attributes by data-uk-xxx in preprocess function and templates.

More infos

I planned to make this change in the modules : UIkit components , Uikit Image Formatter end UIkit Iconpicker , which I use in addition of this theme.

Ideally, I wish theme and modules related to UIkit stays aligned, so I would really like to know what you think of this modification ?

Thanks for your answer.

Feature request
Status

Active

Version

3.0

Component

Code

Created by

🇫🇷France mitsuko

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @andy-blum opened merge request.
Production build 0.71.5 2024