Empty facets still shown with patch from facets ajax issue 3052574

if (!$build) { $is_empty = TRUE; } elseif (isset($build[0]['#attributes']['class']) && in_array('facet-empty', $build[0]['#attributes']['class'])) { $is_empty = TRUE; } // Check if Summary Facet is empty. elseif (isset($build['#items']) && count($build['#items']) == 0) { $is_empty = TRUE; }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 7 months ago →
🇫🇷France GaëlG Lille, France
GaëlG → made their first commit to this issue’s fork.
@ga%C3%ABlg opened merge request.
Status changed to Postponed 7 months ago12:30pm 12 April 2024
Comment 7 months ago →
🇫🇷France GaëlG Lille, France
I first updated MR !2, then I found out that MR !2 was (wrongly it seems) against 1.x. So I made MR !12 with the same changes but against 2.0.x

I switch the issue status to postponed as 🐛 Facets with AJAX not working in most of situations Needs review is not committed for now.
Comment 7 months ago →
🇫🇷France GaëlG Lille, France
Actually it's much more complicated, because if a facet is not empty on initial page load, but empty after AJAX reload (because another facet has been used), the empty facet will still appear (it's title at least). The whole facets block should be recomputed on AJAX reload, but it's not the case.
Actually, I'm not sure this module is so useful, as blockgroup can do kinda the same.

Empty facets still shown with patch from facets ajax issue 3052574

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities