- π¨π΄Colombia camilo.escobar
I also saw the node pages breaking after enabling relative Urls. However, in my case, I have preferred the second fix proposed by @nielsaers: not to use the computed field on view modes, since I'm using this in a headless website and do not want external applications to have to parse the strings to remove the "base:" part.
@nielsaers, are there plans to merge the MR? or at least to provide a patch containing your changes?
- π§πͺBelgium nielsaers
You can get the patch easily from the merge request. By going to the following url: https://git.drupalcode.org/project/computed_breadcrumbs/-/merge_requests...
You should ask the maintainer if they want to merge this. I'm not planning on asking maintainership of this module.
- π¬π§United Kingdom Eli-T Manchester
Hey everyone - thanks for your contributions to this issue. I've taken maintainership of this module as I've inherited one site that uses it and wanted to support for Drupal 10.
We are currently using the patch in [3243177#2] (thanks Leon β€οΈ) and I think this configuration option is a worthwhile addition to the module in general, but we have to decide over the best way forward for the issue described in [3243177#9].
However I could not recreate the issue due to π Un-disabling the Breadcrumbs field when managing display for a content type throws PluginNotFoundException Active ; does anyone have a series of steps to recreate this from a standard install?
I'm minded to go with the second solution in [3243177#9] because a) I can't think of a use case for displaying this and b) that also fixes π Un-disabling the Breadcrumbs field when managing display for a content type throws PluginNotFoundException Active . But it would be really handy to know what other users of the module think; please let me know your thoughts.
Thanks,
Eli
- Status changed to Needs review
over 1 year ago 8:38am 12 July 2023 - π¬π§United Kingdom Eli-T Manchester
This patch is a reroll of Leon's from #3243177-2: Allow return relative URLs β against latest 1.1.x, plus nielsaers' second suggestion from #3243177-9: Allow return relative URLs β .
Apologies for no interdiff - it failed like a coward.
β°elliot.wardβ~/code/d10test/recommended-project/web/modules/contrib/computed_breadcrumbs(gitβ±β 3243177)β±ββ» interdiff 3243177-return-relative-urls-2.patch 3243177-return-relative-urls-15.patch > interdiff-2-15.txt 1 out of 1 hunks failed--saving rejects to '/var/folders/pk/k09fcv3x7sq_pgr3p75t_v540000gp/T//interdiff-1.iPPZQb.rej' interdiff: Error applying patch1 to reconstructed file
- last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - π¬π§United Kingdom Eli-T Manchester
MR 17 is based on the combined patch in #3243177-15: Allow return relative URLs β
- Status changed to Fixed
6 months ago 10:00am 28 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.