white spaces in cache tag

Created on 8 October 2021, about 3 years ago
Updated 16 July 2024, 4 months ago

Problem/Motivation

We got down time recently on Acquia cloud. Our log file showed that if there is a white space at the end of cache tag, it will cause endless re-trying and finally hammer the services down.

The log will be full of lines like this
Tag 'redirect_path:xxxxx ' contains a space, this is forbidden. request_id="yyyyyy"

Steps to reproduce

On Acquia cloud, use https://www.drupal.org/project/domain_path_redirect β†’ 8.x-1.3 which haven't apply this patch https://www.drupal.org/project/domain_path_redirect/issues/3241344 πŸ› trailing spaces from source URL should be trimmed like redirect module Fixed and allow path end with white spaces.

Wait acquia_purge to be triggered and check the drupal-watchdog log and php-errors

Proposed resolution

validate the cache tag key in acquia_purge before send the request.
validate the cache tag key on the service side

Ideally, both side should handle the key properly, but we can't touch the service side.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.1

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom shenzhuxi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States natefollmer

    Any update on this? I'm getting this error in some site studio font settings and can't find anywhere in site studio to change the machine name to remove the space.

  • πŸ‡ΊπŸ‡ΈUnited States plarson

    I'm also experiencing this. We may have added a space when editing the title field and then realized the mistake and fixed it, but the tag remains. How do we delete a tag with a space?

  • πŸ‡ΊπŸ‡ΈUnited States plarson

    We really need a way to prevent this from happening, but if it does happen, how do we get rid of it other than emptying the entire queue?

Production build 0.71.5 2024