Contrib.social

Return order instead of No Content from CartRemoveItemResource

Open on Drupal.org →
Created on 1 October 2021, over 3 years ago
Updated 23 February 2023, about 2 years ago

Problem/Motivation

I'm not sure why, but I thought JSON:API spec wanted a 204 No Content on deletion. I was wrong. I misread this: https://jsonapi.org/format/#crud-deleting-responses-204

Even in the core JSON:API relationship routes it returns the relationship data when an item is removed.

Let's return the order item relationship. We can return the order items and allows leverage includes for the updated order object, just like we do in Add and Update ops.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States mglaman WI, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024