For our use case we only want the sticky for mobile. In the code it checks for $menu.length which will make sure it exists, but not that it's visible.
Also when the nav is hidden, it still tries to calculate the compensation and there is a flicker, despite being no menu to transition into sticky.
- Create a breakpoint (in the CSS sense) and set menu visibility for a certain breakpoint
- Load page at that breakpoint, menu flickers
- Keep page loaded, expand browser, menu now has no correct padding compensation for body.
- Change $menu.length to checking for $(element).is(":visible");, and move this evaluation to on browser scroll so that it will continue to check visibility on browser resize.
Needs review
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I pushed some updates to get the latest in 8.x-1.x. I still think Drupal 9/10 compatibility would have been better handled in a 2.x branch. I had to add in 🐛 jquery.once deprecated in D10 RTBC as well to this merge request as the once library isn't handled currently in 8.x-1.x.