Default submission interval is too long

Created on 15 September 2021, over 3 years ago
Updated 19 July 2024, 5 months ago

If I'm reading the code correctly, the default submission interval is 86400 * 60 * 60 = 311,040,000 seconds = nearly 10 years.
This... is too long.

From simple_sitemap_engines.module:

function simple_sitemap_engines_cron() {
  $config = \Drupal::config('simple_sitemap_engines.settings');

  if ($config->get('enabled')) {
    $interval = (int) $config->get('submission_interval') * 60 * 60;
    $request_time = \Drupal::time()->getRequestTime();

From simple_sitemap_engines.settings.yml

enabled: true
submission_interval: 86400

I think the * 60 * 60 bit should probably be eliminated, so that the submission interval can be specified in seconds as expected, right?

πŸ› Bug report
Status

Fixed

Version

4.0

Component

Code: Search engine integration

Created by

πŸ‡ΊπŸ‡ΈUnited States AaronBauman Philadelphia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024