Map url created incorrectly.

Created on 14 September 2021, over 3 years ago
Updated 16 February 2024, 10 months ago

Problem/Motivation

Not sure what version of core this was originally designed against; but i didn't think the Url::fromUri() function has changed. In the code it sets option for that call as "external" = true; but external is not an option for this method. Also, the documentation for that method suggests an option of "absolute" to create a url with http://; but that does not seem to work either.

I changed //maps.google... to http://maps.google... and that seems to work.

Odd that i am finding this though as this module does nothing with these mistakes. I'll submit patch in a minute.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: cannot reproduce

Version

1.0

Component

Code

Created by

🇨🇦Canada liquidcms

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024