- 🇦🇺Australia mstrelan
I've just tested this patch and noticed I can continuously append .avif on to any image path, e.g image.jpg.avif, image.jpg.avif.avif, image.jpg.avif.avif.avif.
- Status changed to Needs work
about 1 year ago 2:52am 21 September 2023 - 🇦🇺Australia mstrelan
+++ b/src/Controller/ImageStyleDownloadController.php @@ -113,39 +113,12 @@ class ImageStyleDownloadController extends FileDownloadController { - if (!file_exists($image_uri)) { + $image_uri = str_replace('.avif', '', $image_uri); + if ($avifWanted && !file_exists($image_uri)) {
We need to only strip the last
.avif
from the uri rather than replacing all instances of.avif
- Status changed to Needs review
about 1 year ago 3:04am 21 September 2023 - @mstrelan opened merge request.
- 🇦🇺Australia mstrelan
I have opened an MR that incorporates #9 as well as ✨ Do not regenerate the avif file each time it is requested Needs work and 📌 Test coverage Needs review .
-
nterbogt →
committed 462a94f4 on 1.0.x authored by
mstrelan →
Issue #3228314: Filename conflict
-
nterbogt →
committed 462a94f4 on 1.0.x authored by
mstrelan →
- Status changed to Fixed
about 1 year ago 1:37am 4 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.