Use decimal fields for the min / max quantity traits

Created on 5 August 2021, over 3 years ago
Updated 21 August 2024, 7 months ago

Problem/Motivation

Trying to sell minimum quantity of 1/2 kilo using this module, but the value for min and max is an integer.

Proposed resolution

Make the min and max a float instead of an integer.

Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇵🇭Philippines ppblaauw

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇱Israel jsacksick

    Hm... the fields should have been made decimal fields from the start, changing this now requires an update hook and updating all variations...
    We now have a step_order_quantity. For consistency sake, it's also defined as an integer...
    If this is ever fixed, the 3 fields would have to be addressed at the same time.
    There is a much simpler workaround I suppose... by defining 3 additional traits (maximum_order_quantity_decimal, mimum_order_quantity_decimal and step_order_quantity_decimal).

    This isn't an elegant solution but at least removes the need for an update hook... This does make the UX more confusing though...

Production build 0.71.5 2024