- 🇳🇴Norway gisle Norway
Patch partly submitted in 📌 Automated Drupal 10 compatibility fixes Active .
Giving credit.
Automatically closed - issue fixed for 2 weeks with no activity.
pass() was deprecated as part of Simpletest's legacy assertion methods are deprecated →
The content_access tests use this many times, but always in the same way:
if (!\Drupal::moduleHandler()->moduleExists('acl')) {
$this->pass('No ACL module present, skipping test');
return;
}This code checks for the existence of the ACL module and uses pass() to print a message then exit the test if ACL is not present on the test system.
This could be changed to:
$this->assertTrue(
\Drupal::moduleHandler()->moduleExists('acl'),
'No ACL module present, skipping test'
);Which does the same thing, without the deprecated pass() (Note that PHPUnit will automatically end a test case when a failure is encountered, so no explicit "return" is needed.)
However, it makes even more sense just to eliminate this check for the ACL module because test dependencies are supposed to be set by the composer.json file or by the content_access.info.yml file. If those are correct, then the ACL module will *always* be present for testing as it is a *requirement*.
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Patch partly submitted in 📌 Automated Drupal 10 compatibility fixes Active .
Giving credit.
Automatically closed - issue fixed for 2 weeks with no activity.