Bootstrap 5 support

Created on 1 July 2021, almost 3 years ago
Updated 12 April 2024, 2 months ago

Problem/Motivation

Any plans to upgrade this module for Bootstrap 5?

✨ Feature request
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States khaldoon_masud

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States aitala

    The patch does not apply cleanly to the current dev build..

    [drupal]$ patch -p1 < bootstrap_paragraphs-3221758_bootstrap_5_support.patch 
    patching file templates/paragraph--bp-accordion.html.twig
    patching file templates/paragraph--bp-carousel.html.twig
    Hunk #1 FAILED at 168.
    1 out of 2 hunks FAILED -- saving rejects to file templates/paragraph--bp-carousel.html.twig.rej
    patching file templates/paragraph--bp-modal.html.twig
    patching file templates/paragraph--bp-tabs.html.twig
    Hunk #1 FAILED at 156.
    1 out of 1 hunk FAILED -- saving rejects to file templates/paragraph--bp-tabs.html.twig.rej

    There also appears to be an issue with the Accordion template as it generate multiple Card Headers for a single accordion set.

    Eric

  • πŸ‡ΊπŸ‡ΈUnited States aitala

    Here is the watchdog message for the accordion issue

    Warning: A non-numeric value encountered in __TwigTemplate_23d0bab77eff6a65e8ac52129007d10cd7d5f1670936901e303ca8ad095b069e->doDisplay() (line 294 of /var/www/vhosts/drupal9/sites/default/files/php/twig/63d2ccd92e087_paragraph--bp-accordion.h_Z8EjxnMYw4dkBAVMluCoi3D29/TYgRWs6FdRtElJnVzHMZJeaGkqnqjiaTpbTayr_SAEc.php)
    #0 /var/www/vhosts/drupal9/core/includes/bootstrap.inc(347): _drupal_error_handler_real(2, 'A non-numeric v...', '/var/www/vhosts...', 294)
    #1 /var/www/vhosts/drupal9/sites/default/files/php/twig/63d2ccd92e087_paragraph--bp-accordion.h_Z8EjxnMYw4dkBAVMluCoi3D29/TYgRWs6FdRtElJnVzHMZJeaGkqnqjiaTpbTayr_SAEc.php(294): _drupal_error_handler(2, 'A non-numeric v...', '/var/www/vhosts...', 294, Array)
    #2 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(405): __TwigTemplate_23d0bab77eff6a65e8ac52129007d10cd7d5f1670936901e303ca8ad095b069e->doDisplay(Array, Array)
    #3 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
    #4 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
    #5 /var/www/vhosts/drupal9/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
    #6 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
    #7 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('paragraph', Array)
    #8 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
    #9 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
    #10 /var/www/vhosts/drupal9/sites/default/files/php/twig/63d2ccd92e087_field--entity-reference-r_-J1QqR2aXz3pNozwfY5i4dvNk/oGy6O0b-u14oWnp8oBQ3em5cUB63FSUqt5_1jnCLbQI.php(78): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
    #11 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(405): __TwigTemplate_b0c96eebcd8d742943e8aafd3f5f8fca18678182cca4bc150233fc55ddc24335->doDisplay(Array, Array)
    #12 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
    #13 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
    #14 /var/www/vhosts/drupal9/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
    #15 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('modules/contrib...', Array)
    #16 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('field', Array)
    #17 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender(Array)
    #18 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
    #19 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render(Array)
    #20 /var/www/vhosts/drupal9/sites/default/files/php/twig/63d2ccd92e087_node.html.twig_PfMm6JmbUeWLZ-B0MGIVAJtvh/yXU7UeSKq9EsFtmr02MvkOAh8ffoA9GYFhadXtY4BqI.php(110): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
    #21 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(405): __TwigTemplate_9c1125b2afe0309ea069c50d14298273e4732afcdd4982628f3171293b4cb703->doDisplay(Array, Array)
    #22 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling(Array, Array)
    #23 /var/www/vhosts/drupal9/vendor/twig/twig/src/Template.php(390): Twig\Template->display(Array)
    #24 /var/www/vhosts/drupal9/core/themes/engines/twig/twig.engine(55): Twig\Template->render(Array)
    #25 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('core/themes/cla...', Array)
    #26 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('node', Array)
    #27 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, false)
    #28 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(242): Drupal\Core\Render\Renderer->render(Array, false)
    #29 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
    #30 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(243): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
    #31 /var/www/vhosts/drupal9/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(132): Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
    #32 /var/www/vhosts/drupal9/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
    #33 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
    #34 /var/www/vhosts/drupal9/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(142): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
    #35 /var/www/vhosts/drupal9/vendor/symfony/http-kernel/HttpKernel.php(174): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view')
    #36 /var/www/vhosts/drupal9/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
    #37 /var/www/vhosts/drupal9/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #38 /var/www/vhosts/drupal9/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #39 /var/www/vhosts/drupal9/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #40 /var/www/vhosts/drupal9/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #41 /var/www/vhosts/drupal9/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #42 /var/www/vhosts/drupal9/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #43 /var/www/vhosts/drupal9/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #44 /var/www/vhosts/drupal9/core/lib/Drupal/Core/DrupalKernel.php(713): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
    #45 /var/www/vhosts/drupal9/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
    #46 {main}
  • πŸ‡ΊπŸ‡ΈUnited States keiserjb

    Patch is not applying for me. Trying to do it manually.

  • πŸ‡ΊπŸ‡ΈUnited States TLWatson

    Attaching reroll of patch for version 8.x-2.0-beta8.

  • Status changed to Fixed 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States kerrymick Chicago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024