- Merge request !4467Issue #3221101: Deprecate Drupal\Core\Database\Connection::makeSequenceName(), make it internal to PostgreSQL → (Closed) created by mondrake
- last update
about 1 year ago 29,878 pass - Status changed to Needs review
about 1 year ago 8:09pm 24 July 2023 - 🇮🇹Italy mondrake 🇮🇹
Deprecated Drupal\Core\Database\Connection::makeSequenceName() which has no longer purpose with ::nextId() being deprecated too. It's needed by the PostgreSql driver, so added a method specific to pgsql's Connection. That needs to be public because other classes within the pgsql driver need to call it.
- 🇬🇧United Kingdom longwave UK
Why do we need to rename the method? We could just copy it to the Postgres driver and trigger a deprecation for it in the base class?
- last update
about 1 year ago 29,879 pass - last update
about 1 year ago 29,879 pass - 🇮🇹Italy mondrake 🇮🇹
Re. CR, how about just making an addition to https://www.drupal.org/node/3349345 → ?
- last update
about 1 year ago 29,879 pass - last update
about 1 year ago 29,879 pass - Status changed to Needs work
about 1 year ago 9:11pm 25 July 2023 - 🇳🇱Netherlands daffie
@mondrake: You can make an addition to that CR or create a new one. I think we should also have deprecation message test.
- last update
about 1 year ago 29,883 pass - Status changed to Needs review
about 1 year ago 10:41am 26 July 2023 - last update
about 1 year ago 29,881 pass - last update
about 1 year ago 29,881 pass - last update
about 1 year ago 29,881 pass - Status changed to RTBC
about 1 year ago 6:41pm 26 July 2023 - 🇳🇱Netherlands daffie
All my points have been addressed.
All code changes look good to me.
The IS and the CR are in order.
For me it is RTBC. - last update
about 1 year ago 29,888 pass - last update
about 1 year ago 29,910 pass - last update
about 1 year ago 29,948 pass - last update
about 1 year ago 29,941 pass, 1 fail - last update
about 1 year ago 29,955 pass - last update
about 1 year ago 29,955 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,961 pass - Status changed to Fixed
about 1 year ago 8:42pm 16 August 2023 -
longwave →
committed 4365ab3f on 11.x
Issue #3221101 by mondrake, daffie, longwave: Deprecate Drupal\Core\...
-
longwave →
committed 4365ab3f on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.