Deprecate Drupal\Core\Database\Connection::makeSequenceName(), make it internal to PostgreSQL

Deprecated Drupal\Core\Database\Connection::makeSequenceName() which has no longer purpose with ::nextId() being deprecated too. It's needed by the PostgreSql driver, so added a method specific to pgsql's Connection. That needs to be public because other classes within the pgsql driver need to call it.

Why do we need to rename the method? We could just copy it to the Postgres driver and trigger a deprecation for it in the base class?

Re. CR, how about just making an addition to https://www.drupal.org/node/3349345 → ?

@mondrake: You can make an addition to that CR or create a new one. I think we should also have deprecation message test.

Added draft CR https://www.drupal.org/node/3377046 →

All my points have been addressed.
All code changes look good to me.
The IS and the CR are in order.
For me it is RTBC.

Committed 4365ab3 and pushed to 11.x. Thanks!

Also published the change record.

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake → closed merge request !4467