Library icons/icon_picker is attached incorrectly

Created on 20 May 2021, almost 4 years ago
Updated 10 January 2025, 3 months ago

Problem/Motivation

In the IconSelect class the `icons/icon_picker` lib is being added `#attached` and is done by setting the variable as a string, which should actually be an array. If the field's libs get mutated later up in the tree, the lib will be removed since it is not part of an library array. This can result in the field not being displayed properly.

Also, the lib is being added twice which is unnecessary

Steps to reproduce

Add an icon field and make sure some other system will mutate the `#attached.library`. For example the clientside_validation module.

Proposed resolution

Fix the issue.

Remaining tasks

Create a mr.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇳🇱Netherlands aken.niels@gmail.com

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024