Add a drupalci.yml file in order to inhibit coding standards checks (as these are not being addressed)

Created on 18 May 2021, over 3 years ago
Updated 4 March 2023, almost 2 years ago

Problem/Motivation

Any patches to this project are generating lot of additional undesirable noise from the testbot on account of the entire codebase being riddled with coding standards violations.

Of the 70 non-YAML files in the 8.x codebase for this module, phpcs currently has issues with 55 of them (and phpcbf can generate automated changes for some of the issues in 44 of those files).

Multiple issues have been raised in an attempt to resolve this:

* ๐Ÿ“Œ Maintaining drupal coding standards Needs review
* ๐Ÿ› Fix coding standards Postponed
* #2857621: Fix coding standards. โ†’
* #3106512: Drupal Coding Standarad issues โ†’

These are all old and unresolved, however; so it seems clear that this will continue to be an ongoing issue for anyone trying to submit patches, so suppressing these testbot complaints will improve things.

(To be clear, I am strongly in favour of the coding standards being fixed, so that these tests can become the very useful things they are intended to be; but it's very clear that this isn't likely to happen anytime soon.)

Steps to reproduce

Submit almost any patch.

Proposed resolution

Add a drupalci.yml file to inhibit coding standards checks in the automated testing process. This can (and should) be reverted if coding standards are finally fixed; but unless/until that happens, these checks are causing more harm than good.

Documentation for project-specific drupalci.yml configuration is here:

* https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes... โ†’
* https://git.drupalcode.org/project/drupal/blob/HEAD/core/drupalci.yml

Remaining tasks

* Add drupalci.yml file (this issue)
* Fix coding standards (in parent issue)
* Remove drupalci.yml file (future issue)

๐Ÿ“Œ Task
Status

Closed: won't fix

Version

1.0

Component

Miscellaneous

Created by

๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand jweowu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024