Contrib.social

FullyQualifiedNamespaceSniff: phpcbf inserts a use statement before a namespace declaration

Open on Drupal.org →
Created on 17 May 2021, almost 4 years ago
Updated 3 January 2025, 3 months ago

Problem/Motivation

Rule FullyQualifiedNamespaceSniff breaks semantics. Phpcbf inserts a use statement into a wrong position due to the rule.

Steps to reproduce

Version:

* PHP 7.3.11
* phpcbf 3.6.0
* drupal/coder 8.3.12

Input:

<?php

namespace Namespace2;

/**
 * Class C's description.
 */
class C extends \Namespace1\D {
}

Run:
phpcbf --standard=Drupal file.php

Output:

<?php

use Namespace1\D;

namespace Namespace2;

/**
 * Class C's description.
 */
class C extends D {
}

This change breaks the code. Error message:

Fatal error: Uncaught Error: Class 'Namespace2\D' not found

The identifier D must be resolved to \Namespace1\D, but it is actually looked up in \Namespace2. The use statement should have been inserted after the namespace declaration.

🐛 Bug report
Status

Active

Version

8.3

Component

Coder Sniffer

Created by

🇯🇵Japan kensuke-imamura

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024