getBouncesBySubuser caching is over zealous

Created on 5 May 2021, over 3 years ago
Updated 15 March 2023, over 1 year ago

Problem/Motivation

The getBouncesBySubuser method caches all results under a single cid 'sendgrid_reports_bounces' which doesn't take into account changing method arguments.

Also the GetResponse method doesn't catch ServerExceptions.

Steps to reproduce

run getBouncesBySubuser() multiple times with different start/end times or different subusers. You will always get the same results unless you clear cache.

Proposed resolution

Modified the cache key to include the 2 or 3 arguments.

Added an exception handler for ServerExceptions

πŸ› Bug report
Status

Closed: outdated

Version

1.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada lambic

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024