- 🇨🇦Canada jigarius Montréal
The patch in comment 17 doesn't apply on version 4.0.14.
Suggestion: I was wondering, can't we try the new merge request work flow instead of the patches? It will make it clear whether the merge can still be performed.
- @dshumaker opened merge request.
- 🇺🇸United States dshumaker
@jigarius I added patch 17 to the Merge request: https://git.drupalcode.org/project/environment_indicator/-/merge_request...
- Status changed to Needs review
almost 2 years ago 5:46pm 22 June 2023 - 🇺🇸United States devkinetic
So this solution still requires editing settings.php to add the machine name of the config entity. I think it would be more useful if we did away with the settings.php stuff entirely and instead did regex/hostname matching on the active environment. I have an issue at 📌 Implement the current environment as a service and utilize plugins Active where I use that approach vs the MR on this issue. If you agree with me, I'd welcome closing this issue out and moving the work over there. One thing I really liked about this issue is you created a service, rather than stuffing ToolbarHandler with the logic.
- 🇨🇦Canada jaypan Victoria, BC
I've actually just started setting up config splits, and working with the Environment Indicator UI module to set up the various environments, and stopped using this patch. I can see how this functionality could/would be beneficial for some people, but for me it because irrelevant with the Indicator UI module.