Coding standards and safer shell argument processing

Created on 13 April 2021, over 3 years ago
Updated 4 May 2023, over 1 year ago

Problem/Motivation

The code make use of shell_exec but doesn't check that the binary exists before using it.

Resulting in warnings showing up in the stderr output.

Steps to reproduce

Uninstall ImageMagick and and GraphicsMagick and run drush thumbnails:refresh.

Proposed resolution

Add a check that the binary exists before using it. As well as ensure that all the shell arguments are properly escaped.

Remaining tasks

Provide a patch.

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024