Use an allowed list of classes for glb_classes() instead of disallowed classes

Created on 8 April 2021, about 4 years ago

Updated 11 February 2024, over 1 year ago

Problem/Motivation

In the glb_classes() twig filter a list of classes is defined that should not be prefixed. Since contrib modules could add all kinds of unknown classes (found this using the maxlength module) this could lead to unexpected issues.

Steps to reproduce

Create an inline block type with a field using the maxlength module (for example).
Try to add the block.
The maxlength module javascript does not work as expected.

Proposed resolution

I think it would be safer to create a list of explicit classes that should be prefixed, instead of listing classes that should not be.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands seanB Netherlands

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!10Use an allowed list of classes for glb_classes() instead of disallowed classes
Closed
🇳🇱Netherlands seanB
updated over 1 year ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !10Issue #3207788: Use an allowed list of classes for glb_classes() instead of disallowed classes → (Closed) created by seanB
Comment over 1 year ago →
System Message
Grimreaper → closed merge request !10

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024