- First commit to issue fork.
- @eojthebrave opened merge request.
- πΊπΈUnited States eojthebrave Minneapolis, MN
This new MR incorporates the fix from #4 for the 'non_renewing' subscription state. And adds tests for the RecurlySubscriptionList controller since it didn't previously have any. That, in addition to other things, validate this fix. I realize adding all those additional tests is probably overkill for this issue. But the test class didn't exist at all, and it felt silly to create the class with a test that only tests one of the many different possible 'states' a subscription can be in.
Adding these tests also pointed out an issue with the call to `recurly_url()` in \Drupal\recurly\Controller\RecurlySubscriptionListController::subscriptionStateMessage for 'past_due' subscriptions. Which is fixed in this MR.
In order to make the tests work I refactored the code in RecurlySubscriptionList that creates a static cache of the results from looking up an account's past due subscriptions. The refactored version allows the static cache to be reset. I also had to refactor the way that the RecurlyMockClient stores it's list of previously issued API requests because the current version doesn't allow you to check both 'HEAD', and 'GET' methods for the same URI because the array is keyed by URI instead of method.
-
eojthebrave β
committed a853af29 on 4.x
Issue #3205886 by eojthebrave, Suresh Prabhu Parkala, loze: [D8]...
-
eojthebrave β
committed a853af29 on 4.x
- Status changed to Fixed
about 2 years ago 12:54pm 7 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.