Prevent exceptions on checkout page from PaymentProcess checkout pane when order_total is null

I bumped into this very same problem with a custom module.
Setting major because the project page says it blocks https://www.drupal.org/project/commerce_admin_checkout →
Reviewed the code and can confirm that it trivially prevents the exception mentioned in the IS.
Triggered test again as due diligence.
Can confirm that this just finishes the related predecessor issue.
Setting RTBC based on that.

But I don't consider this fix as legit... How in the world does it make sense to skip payments when the order total price is NULL? This is just a malformed order... Order total should be 0, not NULL.

I can tell you my use case: The checkout process is entered with an empty order, and the order is filled there (and never empty on completion). This makes a fantastic UX for a broad range of use cases.
(I tried a lot to do it differently, but all other approaches were quite doomed.)

I suppose the approach in the commerce_admin_checkout module of @zengenuitiy is similar.

Also i thought if you committed the same thing in the predecessor issue #2968079: Prevent exceptions on checkout page when order_total is null → , there's no discussion about this.

About data model integrity you don't have to evangelize me, i'm all for this, and i don't see that this change adds a new harm to this.

What u think?

If you cnanged your mind and say the predecessor issue should never have got committed, i can imagine the following: In the above use case of an order without items, instead of a null price throwing, the order refresh sets a zero price in that case. I can work on that if you prefer.

Committed, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.