tablesortertheme.css not included unless blue/green theme selected

Created on 3 March 2021, almost 4 years ago
Updated 19 July 2023, over 1 year ago

Problem/Motivation

Module does not not include the tablesortertheme.css base file, unless blue or green are selected as themes. The tablesortertheme.css should be added as the default.

πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jenlampton

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ͺπŸ‡ΈSpain juanolalla

    I'm reopening the issue because despite the previous solution was considered not applicable, the problem is still there.

    I think this is a pretty common use case, where you want to use the module and start by using the default css that comes with it (in tablesortertheme.css), like the header sorter images (arrows) and the rest of base theming. You could then adjust that with your own css in the theme.

    Right now this is not possible, unless you select green or blue, and then you would need to override the css to remove that blue or green extra theming.

    I understand that the first option was intended to be just the "System Default" theme, which means no specific css at all; and so for, adding tablesortertheme.css to that could be considered inappropriate and alter the styling of other sites with existing custom css without that file.

    So I came with a different and simple solution from this missing use case: to create a new option to select "Tablesorter's Default" theme, so that way a user can count on the base css from tablesortertheme.css, without having to choose unwanted blue or green theme. Attaching the patch.

Production build 0.71.5 2024