- 🇺🇸United States jrb Raleigh-Durham Area, NC, USA
Patch in #4 re-rolled for 2.0.6.
- 🇳🇿New Zealand garethhallnz
I have tested the patch in #6, and while it does resolve the render array key errors, it also causes the ArrayWidget to be empty, i.e., no items show in the facet block. The issue seems specifically related to the array keys 'values' and 'value' in methods prepare() and generateValues(), respectively.
Here is an updated patch.
- last update
about 1 year ago Patch Failed to Apply - 🇺🇸United States jrb Raleigh-Durham Area, NC, USA
@RohitRawat676
While it is nice to make the code follow coding standards, it's not good practice to change code unrelated to the issue at hand in an issue patch. In this case, the previous patch changed 3 lines, but your patch changes over 150 lines. This makes it much more difficult to test that the patch fixes the issue without introducing any other problems.
If you would like to suggest changes to make the code of this module (or any module) follow Drupal coding standards, that would be welcome, but it would be best to create a separate, new issue and add your patch there.
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply