-
podarok β
committed 24227385 on 2.0.x authored by
Odai Atieh β
Issue #3197629 by JordiK, Odai Atieh: New API hooks to react on inline...
-
podarok β
committed 24227385 on 2.0.x authored by
Odai Atieh β
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Needs review
over 1 year ago 5:49pm 9 December 2023 - π©πͺGermany geek-merlin Freiburg, Germany
Short review: I like the idea, but this needs some work. If someone is still wanting to work on this, i can give a full review.
- π¦πΉAustria jordik
I can work on this.
@geek-merlin: What exactly needs to be done? - π¦πΉAustria jordik
Re-rolled the patch for 3.x.-dev.
There was a change in the function determineBundle introduced in π Wrong bundle form is displayed if user has permissions to create only one of the available bundles Fixed .
It is now using $this->getCreateBundles() instead of $this->getTargetBundles() to solve the issue of user permissions to create certain bundles to be respected. Passed $context as variable to the function to allow for the API call.
Works now as expected. Please review. - First commit to issue fork.
- π¬π§United Kingdom hocu London
You are lifesavers!
I tested the
inline_entity_form_entity_save
hook so far, and everything works great. I took the liberty of creating an issue fork, just to clean up some warnings raised by PhpStorm (nitpicking mode on π).Once I test the other hooks, I will update the status to RTBC.
- π¬π§United Kingdom hocu London
Tested with latest D10.4. All good, thank you. Converting to RTBC now.