- 🇮🇳India KumudB Ahmedabad
I have reviewed the patch #5, its working for me in Drupal version 8.x and 9.x , there is no error while installing the module Smartmenus.js. I have test it on my local.
After trying to install the module in drupal 9.1.3 I get an empty warning box in the module page, the logs report this:
Notice: Undefined index: description in drupal_check_module() (line 1024 of /var/www/localhost/htdocs/drupal9/core/includes/install.inc)
#0 /var/www/localhost/htdocs/drupal9/core/includes/bootstrap.inc(305): _drupal_error_handler_real(8, 'Undefined index...', '/var/www/localh...', 1024)
#1 /var/www/localhost/htdocs/drupal9/core/includes/install.inc(1024): _drupal_error_handler(8, 'Undefined index...', '/var/www/localh...', 1024, Array)
#2 /var/www/localhost/htdocs/drupal9/core/modules/system/src/Form/ModulesListForm.php(434): drupal_check_module('smartmenus')
#3 /var/www/localhost/htdocs/drupal9/core/modules/system/src/Form/ModulesListForm.php(452): Drupal\system\Form\ModulesListForm->buildModuleList(Object(Drupal\Core\Form\FormState))
#4 [internal function]: Drupal\system\Form\ModulesListForm->submitForm(Array, Object(Drupal\Core\Form\FormState))
#5 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/Form/FormSubmitter.php(113): call_user_func_array(Array, Array)
#6 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/Form/FormSubmitter.php(51): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState))
#7 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/Form/FormBuilder.php(593): Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object(Drupal\Core\Form\FormState))
#8 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/Form/FormBuilder.php(321): Drupal\Core\Form\FormBuilder->processForm('system_modules', Array, Object(Drupal\Core\Form\FormState))
#9 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\system\Form\ModulesListForm), Object(Drupal\Core\Form\FormState))
#10 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#11 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#12 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#13 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#14 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#15 /var/www/localhost/htdocs/drupal9/vendor/symfony/http-kernel/HttpKernel.php(158): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#16 /var/www/localhost/htdocs/drupal9/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#17 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#18 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#19 /var/www/localhost/htdocs/drupal9/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#20 /var/www/localhost/htdocs/drupal9/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#21 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#22 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#23 /var/www/localhost/htdocs/drupal9/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /var/www/localhost/htdocs/drupal9/core/lib/Drupal/Core/DrupalKernel.php(706): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /var/www/localhost/htdocs/drupal9/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#26 {main}Unfortunately I don't have the expertise to understand and fix the problem, I tried the stable version and the dev version too.
Needs review
1.1
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I have reviewed the patch #5, its working for me in Drupal version 8.x and 9.x , there is no error while installing the module Smartmenus.js. I have test it on my local.