Allow configuring the core_version_requirement of features per bundle

Created on 2 February 2021, almost 4 years ago
Updated 1 June 2023, over 1 year ago

Problem/Motivation

Follow-up to #3154650-15: "core_version_requirement" property is missing in the info.yml file for modules generated by Features β†’ and #3154650-16: "core_version_requirement" property is missing in the info.yml file for modules generated by Features β†’ .

Steps to reproduce

Proposed resolution

  • Add ::getCoreVersionRequirement() and ::setCoreVersionRequirement() methods to FeaturesBundleInterface.
  • Add a form element to edit core version requirement.

Would break backward compatibliity as it involves a change to the FeaturesBundleInterface.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada nedjo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States dave reid Nebraska USA
  • πŸ‡ΊπŸ‡ΈUnited States dave reid Nebraska USA

    It would be maybe just nice if once the .info.yml file was written initially, if it didn't attempt to update that line afterwards, or only if it matches the previous value that was set by the module.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    It would be maybe just nice if once the .info.yml file was written initially, if it didn't attempt to update that line afterwards, or only if it matches the previous value that was set by the module.

    Agreed. I think this is the correct business logic. The current logic is problematic when, say, a Features module has been made compatible for the next major version of Drupal while the site is still running on a previous version. Another simple way of stating the proposed business logic change is "If a module already has a core_version_requirement set, don't try to change it." This would be different than this issue title's stated goal of allowing configuration, but would also avoid the stated B/C breaking consideration.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    The merge request proposes to change the logic to "If a module already has a core_version_requirement set, don't try to change it."

  • Pipeline finished with Failed
    2 days ago
    Total: 313s
    #373964
Production build 0.71.5 2024