LIbrary not loaded - no CDD and expand code boxes on hover not working

Created on 24 December 2020, almost 4 years ago
Updated 23 May 2023, over 1 year ago

Problem/Motivation

Enabling "Expand code boxes on hover" filter setting has no effect

Steps to reproduce

1. Configure a text format with codefilter and codefilter "Expand code boxes on hover" enabled
2. Create a content node that uses the newly created text format with a code block that contains a very long line.

Proposed resolution

I am attaching a patch that loads the js file when "Expand code boxes on hover" is enabled.
I also noticed that the CSS file is never loaded so I am also loading it all the time.

Remaining tasks

Review ;-)

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Closed: outdated

Version

1.0

Component

Code

Created by

🇫🇮Finland msameer

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇬🇧United Kingdom joachim

    > Expand code boxes on hover not working

    I fixed this before I saw this issue -- the problem was, as shown in the fix here, that the library wasn't being included.

    Splitting the library in two is a good improvement, but not related to this bug.

Production build 0.71.5 2024