Use relative URL for export button

Created on 18 December 2020, about 4 years ago
Updated 9 December 2022, about 2 years ago

Problem/Motivation

The data export download is blocked in Chrome (see https://blog.chromium.org/2020/02/protecting-users-from-insecure.html) and the data export URL was using http instead of https.

Steps to reproduce

Attach a data export to a view on an https site and attempt to download by clicking its orange button in Chrome. Dev Console should reference the above Chromium blog post.

Proposed resolution

Change the absolute URL of the export download to a relative one.

Remaining tasks

See attached patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada bsuttis

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΈπŸ‡°Slovakia lubwn

    Confirming #18 works for me. I have drupal set up behind reverse proxy and in fake subfolder so I have some funky staff going on in settings.php file to account that.

  • mademo β†’ made their first commit to this issue’s fork.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    Patch Failed to Apply
  • #18 works for me on Drupal 10.2.2 with views_data_export 8.x-1.4.

  • #18 works for me on Drupal 10.2.2 with views_data_export 8.x-1.4.

  • Status changed to Closed: works as designed about 1 month ago
  • πŸ‡¬πŸ‡§United Kingdom steven jones

    I'll admit that it's a bit odd that we're generating absolute URLs for the attachment links. I'm not sure why we need to do that, does anyone in this thread know? They could be relative links and then things should work fine.

    Equally, if Drupal doesn't know it's running behind https, you should sort that issue out with your setup, it's not on VDE to sort that out.

    I'm going to close this out, since if you have a correctly configured Drupal, VDE generates a link correctly, even if it does generate an absolute link.

Production build 0.71.5 2024