- 🇬🇧United Kingdom sergiur London, UK
Thanks for the patches, they're really helpful! The latest patch in this issue causes a deprecation warning with PHP 8.1 described here: 📌 Deprecated: Optional parameter $menuId declared before required parameter $depth in MenuItems.php on line 117 Closed: duplicate . I've closed the other issue as a duplicate, I believe the fix should happen here.
- @sergiur opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 4:14pm 6 September 2023 - 🇬🇧United Kingdom sergiur London, UK
changed the $menuId param to be required, now that it's followed by other params it is effectively required anyway
- 🇬🇧United Kingdom sergiur London, UK
ahh sorry did this on v2.. will need to do again on v3
- Assigned to sergiur
- Status changed to Needs work
9 months ago 10:36am 14 February 2024 - Issue was unassigned.
- Status changed to Needs review
9 months ago 11:21am 14 February 2024