Providing tests

The namespace in the test file was incorrect so test could not be run, as the error of not finding the class was thrown. After correcting the namespace the tests were successfully run and all of them passed. Because of that change, leaving it to needs review, but I think it can get merged.

I went through the code again and they don't really make much sense to me. We are mocking the responses of services and asserting that responses are equal to mocked responses.

An example from here: https://git.drupalcode.org/project/search_api_meilisearch/-/merge_reques...

$this->mockClient->method('getIndex')->willReturn($this->mockIndexes);
$this->mockIndexes->method('search')->willReturn($results_data);

$results = $meilisearch_api_service->search('movies', 'DieHard', ['limit' => 10]);
$this->assertEquals($results_data, $results);

We are saying that the search method will return a mocked data, calling that search method and asserting that the result is equal to the mocked data, so the test is useless.

I think it's better to add a real meilisearch docker container behind the tests and make real calls to meilisearch https://www.meilisearch.com/docs/learn/cookbooks/docker. This way we could test everything from auth, indexes, fields, search etc.

This should be possible by adding a drupalci.yml file in a module root folder https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes... → .

I'm setting this back to needs work.

I've added a custom drupalci.yml with meilisearch docker container attached and a connection test as a basic reference for other tests.

I've moved initial tests done by @rokzabukovec to separate classes and they use a meilisearch instance. We are still missing a lot of test scenarios however I think it would be better to merge this and then open new issues to add specific tests. Also existing issues would benefit from having this issue merged so tests can also be added based on this code. So I am changing this to Needs review.

The tests are passing and as mentioned some tests are missing and I agree with the: "Also existing issues would benefit from having this issue merged so tests can also be added based on this code" so marking it as RTBC.

Merged, thanks.

Automatically closed - issue fixed for 2 weeks with no activity.