srcset support and default dimensions

Created on 11 December 2020, over 3 years ago

Updated 28 February 2023, over 1 year ago

Hi,

I've tried your module in one of our projects and find it very useful! Ran into two issues though, addressed in the attached patch.

I've added a preprocess function for responsive images to also replace images referenced in their srcset attributes
I've encountered quite a few images where no height and width were passed to the preprocess function. That results in your module requesting just https://via.placeholder.com/x.png, which obviously fails. So the patch just adds arbitrary fallback values of 200px to ensure no request fails.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany marcoliver Neuss, NRW, Germany

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇩🇪Germany redbeed Münster, NRW
Hello,

I updated the patch so it works with the newest version of Drupal (9.5.3).
Based on the responsive setting an image will called, I had to extract it from the given srcset.
Comment about 1 year ago →
System Message

Tom Grootjans → committed 9603eba9 on 8.x-1.x authored by redbeed →
Issue #3187834 by marcoliver, redbeed: srcset support and default...

Production build 0.69.0 2024