ISBN - Add Ludwig integration

Created on 15 October 2020, about 4 years ago
Updated 26 May 2023, over 1 year ago

Add Ludwig integration as an alternative for Composer installation.

ORIGINAL POST

I've downloaded the ISBN module but can't work out how to get enable the ISBN Field in a conventional way (not per composer).
I downloaded the zipfile, unzipped and have it sitting off the root directory but no joy.

/core
/libraries
-- nicebooks*
/modules
/themes
...

* the downloaded zip was "isbn-master" (also changed to just 'isn' still no joy).

There was an issue reported and looks like the reply back was to say that documentation would be added:
https://www.drupal.org/project/isbn/issues/2878502#comment-12089804

"That's fair and I'll create a documentation page with these instructions."

I may have overlooked this, but is this available?

Many thanks.

Feature request
Status

Fixed

Version

1.3

Component

Code

Created by

🇬🇧United Kingdom JeniferTucker

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇭🇷Croatia devad

    This simple patch should do the job.

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    12 pass
  • @megachriz opened merge request.
  • 🇳🇱Netherlands megachriz

    I've tested the patch in #3. After installing the Ludwig module it downloaded the required libraries, so I think that the patch works well!

    In the issue fork I also made the following changes:

    • I documented that the library can be installed using the Ludwig module in the README file.
    • In isbn_requirements() I mentioned as well that the Ludwig module is an option for installing the library.
    • I tested the module by removing the library after installation and that caused a fatal error. Therefore I added a check in IsbnToolsService for the availibility of the library - and throw a RuntimeException if it is missing.
  • 🇭🇷Croatia devad

    Thanks for all the improvements.

    The Ludwig guide link

    Instead of:

    Steps:
    
    1. Download and install the Ludwig module.
       https://www.drupal.org/project/ludwig
    
    2. Download and install this module.
    
    3. Ludwig generates a listing of libraries required by those modules. The
       Packages page at admin/reports/packages provides a download link for each
       missing library along with the paths where they should be placed.
    

    It is probably better to just give to the users an official Ludwig guide link:

    Ludwig Installation and Usage

    Outdated info

    3. Ludwig generates a listing of libraries required by those modules. The
    Packages page at admin/reports/packages provides a download link for each
    missing library along with the paths where they should be placed.

    This part is outdated. Ludwig has the automatic download and unpack functionality now, so no need for manual downloading and unpacking of library archives to the specified folders as previously. Both installing and updating the libraries with Ludwig is much more convenient now.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    12 pass
  • 🇳🇱Netherlands megachriz

    @devad
    Thanks for your review! I looked at how the Address project documented Ludwig support in their Readme file and adjusted the Readme here accordingly. I left out information about using a dev version, as I thought that may be less relevant for the ISBN project. I doubt that there will be much changes until adding Drupal 11 support will become relevant.

    I guess that the Readme file in Feeds Extensible Parsers (an other project that I maintain) also need to be updated, as that one still contains the outdated instructions.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    12 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    12 pass
    • MegaChriz committed d0c35ce5 on 8.x-1.x
      Issue #3177122 by MegaChriz, devad: Added Ludwig integration +...
  • Status changed to Fixed over 1 year ago
  • 🇳🇱Netherlands megachriz

    I merged the code!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024