CKEditor breaks while uploading image and saving before the image upload is finished

Created on 1 October 2020, about 4 years ago

Updated 26 May 2023, over 1 year ago

Problem/Motivation

CKEditor breaks when you are uploading an image but try to save image upload dialog before the image has finished uploading. This happened in both 8.9.x and 9.1.x as well.

Steps to reproduce

- Install fresh new Drupal
- Go to new article creation page
- Click the "image upload icon"
- When the image upload dialog box appears, upload a large sized image that takes many seconds to upload
- While the image is still being uploaded, hit "save" on the dialog box
- Wait until the ajax request for the image upload is completed
- After the image upload xhr request has finished, it should break the underlying CKEditor
- Demo: https://www.loom.com/share/2c8559820a274f11a4bd31cbfbb9625f

What behavior were you expecting?

- CKEditor should keep working
- Error should be visible as now

What happened instead?

- CKEditor disappeared once image upload xhr was completed

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇳🇵Nepal gupta324

Live updates comments and jobs are added and updated live.

CKEditor in core

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Patch Failed to Apply
Comment over 1 year ago →
🇨🇦Canada leeomara Whitehorse, Yukon
I wasn't able to get the patch from #12 to apply on Drupal 9.5 (would fail to patch core/misc/active-link.js). I suspect the whitespace changes from https://git.drupalcode.org/project/drupal/-/commit/77e12397f5dd5e0a49ed1... are the issue.

I've attempted to re-roll the patch from #12 against the Drupal core 9.5.x branch. This patch does apply for me on 9.5.9, though I'm a novice at this, so please check my work.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024