Contrib.social

Third Party Settings like Antibot and Honeypot can't be disabled

Open on Drupal.org →
Created on 21 September 2020, over 4 years ago
Updated 7 February 2024, 11 months ago

Problem/Motivation

When a third party module is enabled (in particular antibot and honeypot), it may no longer be disabled from the settings page.

I believe this behaviour might've been introduced in #3133717: Custom third party settings are lost when General settings page is saved → or has always been there.

The issue is because \Drupal\webform\EntitySettings\WebformEntitySettingsGeneralForm::save() only calls $webform->setThirdPartySetting() and no longer detects removed third party settings as they're typically unset when inactive.

Steps to reproduce

  • Install Antibot module
  • Enable Antibot module as a third party setting on a form
  • Attempt to disable the Antibot integration

Proposed resolution

Add logic which allows the removal of third party settings.

Remaining tasks

Provide a patch addressing the issue.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Fixed

Version

5.0

Component

Code

Created by

codebymikey

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 11 months ago →
    🇫🇷France pacproduct

    Hi,

    I feel like I'm facing this exact issue with webform version 6.2 (on Drupal 10): Honeypot's checkbox "Add time restriction to XXX webform" cannot be unchecked once it's been checked. I had to manually edit my webform's yaml configuration file to remove this option.

    In Honey pot's global configurations, I do not have the "protect all forms" option checked.

    Am I missing something, or should a new issue be opened?

  • Comment 11 months ago →
    🇦🇺Australia imclean Tasmania

    @pacproduct it looks like all settings need to be disabled at once.

    Steps to reproduce:

    1. Enable both "Protect Enquiries webform with Honeypot" and "Add time restriction to Enquiries webform"
    2. Try to disable either setting individually

    The workaround is to disable both then enable the one you want.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024