Use HTTPS instead of FTP (D7 version)

Created on 20 August 2020, over 4 years ago
Updated 25 September 2023, about 1 year ago

Problem/Motivation

Currently this module uses ftp to access the country lists. This is problematic, because you have to open up a lot of ports, since the server uses passive mode.
The ripe servers also provide https access to those files, the module should use those urls instead.

There is existing issue but was changed to Drupal 8 version ( https://www.drupal.org/project/ip2country/issues/2571835 ✨ Use HTTP instead of FTP Needs review ), so this one is for Drupal 7 version.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Closed: duplicate

Version

1.0

Component

Code

Created by

πŸ‡ΈπŸ‡°Slovakia phrabovcin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΈπŸ‡°Slovakia sano

    Work for me with php 8. Thanks

  • Status changed to Closed: duplicate about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    This is done differently than the proposed patch for the current branch of the module. See ✨ Use HTTP instead of FTP Needs review . I don't want a different implementation in the two branches.

    The way issues like this are normally handled in Drupal is to patch the current branch first, then backport that patch to previous versions if there is community interest. We always work on the current branch first, because that way the patch gets into the code going forward - if it is committed to a previous branch first then chances are the changes will remain in the previous branch and the functionality will not make it into the current branch.

    So in general we don't have separate issues for the different branches. We fix things in the current branch first and then backport those fixes.

    This feature can be implemented in the same way in both branches, with only minor differences (variable vs config) and some minor test changes. Let's get the 2.0.x branch committed first, in ✨ Use HTTP instead of FTP Needs review , then that issue can be set to "Patch "(to be ported)" and the 2.0.x patch can be backported to 7.x-1.x in that issue to ensure the code remains the same in the two branches.

Production build 0.71.5 2024