- 🇬🇧United Kingdom MrDaleSmith
Updated patch as it no longer applied to the latest version.
-
jsacksick →
committed 1b091171 on 8.x-2.x authored by
andrewbelcher →
Issue #3165903 by andrewbelcher, MrDaleSmith: Use NOT isAnonymous rather...
-
jsacksick →
committed 1b091171 on 8.x-2.x authored by
andrewbelcher →
-
jsacksick →
committed d9290874 on 3.0.x authored by
andrewbelcher →
Issue #3165903 by andrewbelcher, MrDaleSmith: Use NOT isAnonymous rather...
-
jsacksick →
committed d9290874 on 3.0.x authored by
andrewbelcher →
- Status changed to Fixed
about 1 year ago 12:03pm 7 April 2023 - 🇮🇱Israel jsacksick
I think this makes the code a little bit less readable... But if this helps with your usecase... The thing is, if we follow your reasoning then what guarantees that the
isAnonymous()
method will always contain logic that work in our cases?I'm guessing the problem is how core named its methods,
isAuthenticated()
makes it sound the user is actually authenticated while the check performed only ensures the$user->uid() > 0
.Since I committed an equivalent patch already previously, decided to also commit this one though we'll probably have to make sure to not forget about this when it comes to adding similar checks in the future.
Automatically closed - issue fixed for 2 weeks with no activity.