Version 1.0.1 of the cookie class, from this URL: http://simon.s3.iubenda.com/iubenda-cookie-class causes errors with PHP 7.3, and greatly degrades site performance. Error:
Warning: preg_match(): Compilation failed: invalid range in character class at offset 4 in simple_html_dom->read_tag() (line 1375 of /code/sites/all/libraries/iubenda-cookie-class/simple_html_dom.php).
Install using drush, or following the steps on the module home page. Enable the module on a live site with an iubenda profile.
Use the newest version of the module, from here: https://github.com/iubenda/iubenda-cookie-class
And also update code to change references to Page class (1.0.1) to iubendaParser (4.1.2) - see patch.
I'm not taking responsibility right now for updating the version installed by drush. Retroactively changing the class name (in this patch) is going to break sites who have the 1.0.1 version installed. That means we need an install hook to either replace the library or just deactivate the module until the user installs the correct one.
All in all I think it should be at the user's discretion to install the library, as automatic install doesn't work for all use cases (e.g. Pantheon) and causes legacy code problems like this one. (This is obviously a problem best solved by composer in Drupal 8. Composer Manager might be a possible direction?) At any rate, anyone else using this module on PHP 7.3 should be able to solve the problem using this patch and the newer library, and I wanted that to be known.
Does the maintainer have suggestions on how to integrate this change without breaking users of the 1.0.1 version?
Fixed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.