- First commit to issue fork.
- Status changed to Needs work
10 months ago 6:03am 5 June 2024 - 🇬🇧United Kingdom scott_euser
Didn't manage to get started on any tests, but sorted out the various phpstan/phpcs issues
- 🇬🇧United Kingdom scott_euser
Not sure how far you all want to take this, but I guess the something is better than nothing is probably a start. Will try to find time to cover:
- The different Formatters (lazy/non-lazy) at least at a basic level
- The default settings at least at a basic levelSide note: My more selfish goal here is to have enough test coverage to get to a point where you might consider to merge 🐛 Views reference is adding many query string variables to the pager URLs RTBC in as my agency deals with think tanks with 10s of thousands to 100s of thousands of content items and we use this module quite a bit as a foundation for a minimal control of lots of exposed filtering options without needing to know and build VIews (so thank you for the great foundation, just trying to give back a bit where I can).
- Status changed to Needs review
10 months ago 9:52am 11 June 2024 - 🇬🇧United Kingdom scott_euser
Note that this contains the code from #3317635: Coding standards → in order for tests to actually pass.
- 🇬🇧United Kingdom scott_euser
Follow-ups created:
- 🇬🇧United Kingdom scott_euser
Merging from upstream after merge of phpcs #3317635: Coding standards → , thanks!
- last update
10 months ago 1 pass, 2 fail -
seanB →
committed b9731609 on 8.x-2.x authored by
scott_euser →
Resolve #3161731 "Basic test coverage"
-
seanB →
committed b9731609 on 8.x-2.x authored by
scott_euser →
- Status changed to Fixed
10 months ago 10:34am 11 June 2024 - 🇳🇱Netherlands seanB Netherlands
This only adds test coverage which looks pretty good for a first setup. We can always expand/improve later. Merged for now, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.