The documentation for \Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface::getFieldStorageDefinition says that methods always returns \Drupal\Core\Field\FieldStorageDefinitionInterface:
* @return \Drupal\Core\Field\FieldStorageDefinitionInterface
* The field storage definition.
But implementation \Drupal\Core\Entity\EntityDefinitionUpdateManager::getFieldStorageDefinition can return NULL.
/**
* {@inheritdoc}
*/
public function getFieldStorageDefinition($name, $entity_type_id) {
$storage_definitions = $this->entityLastInstalledSchemaRepository->getLastInstalledFieldStorageDefinitions($entity_type_id);
return isset($storage_definitions[$name]) ? clone $storage_definitions[$name] : NULL;
}
Add NULL as return type to the interface documentation.
- Reviews needed
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
> I think we should deprecate returning NULL and throw an exception (in the D10 future) instead.
Agreed, but could we reset this issue to being a documentation quick fix, so the docs correctly reflect what the code does, and file a separate issue to improve the code?