- π¬π§United Kingdom steven jones
Approach seems sensible, but I'm not sure about the exact implementation:
+++ b/src/Plugin/views/display/DataExport.php @@ -898,13 +898,14 @@ class DataExport extends RestExport { + $filename = basename($url);
Is it valid to call
basename
on a URL?Seems like this might be working slightly by accident? Is it possible that this URL would contain a
/
that would trip it up? - Status changed to Needs work
4 months ago 8:13pm 29 December 2024 - π«π·France pbonnefoi
The filename is not working with batch export. I'm having issues as well using the basename (some time encoding is not working properly). Is there any better fix than this ? (I'm trying to solve this on my side as well).
- Merge request !74Issue #3158926: Download link should contain filename β (Open) created by pbonnefoi
- π«π·France pbonnefoi
The basename works fine in this case. I added some tweaks due to wrong encoding on some date format.
- π«π·France pbonnefoi
Add the proper patch for the 1.5 version (otherwise it does not apply). Sorry for all the branches created ^^
- π«π·France pbonnefoi
pbonnefoi β changed the visibility of the branch 3158926-fix-filename-in-batch-mode to hidden.
- π«π·France pbonnefoi
pbonnefoi β changed the visibility of the branch 3158926-fix-filename-in-batch-mode to hidden.
- π«π·France pbonnefoi
pbonnefoi β changed the visibility of the branch 3158926-fix-filename-in-batch-mode to hidden.
- π«π·France pbonnefoi
pbonnefoi β changed the visibility of the branch 3158926-fix-filename-for-batch-export to hidden.