PHP 7.4 Compatibility & Drupal standards

FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/acl.api.php ------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------ 33 | ERROR | [x] Comments may not appear after statements 33 | ERROR | [x] Inline comments must start with a capital letter 39 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------ FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/acl.admin.inc -------------------------------------------------------------------------------------------- FOUND 16 ERRORS AFFECTING 15 LINES -------------------------------------------------------------------------------------------- 18 | ERROR | [x] Short array syntax must be used to define arrays 24 | ERROR | [x] Short array syntax must be used to define arrays 48 | ERROR | [x] Short array syntax must be used to define arrays 55 | ERROR | [x] Short array syntax must be used to define arrays 60 | ERROR | [x] Short array syntax must be used to define arrays 62 | ERROR | [x] Short array syntax must be used to define arrays 64 | ERROR | [x] Short array syntax must be used to define arrays 68 | ERROR | [x] Short array syntax must be used to define arrays 71 | ERROR | [x] Short array syntax must be used to define arrays 79 | ERROR | [x] Short array syntax must be used to define arrays 83 | ERROR | [x] Short array syntax must be used to define arrays 86 | ERROR | [x] Short array syntax must be used to define arrays 141 | ERROR | [x] Short array syntax must be used to define arrays 141 | ERROR | [x] Comments may not appear after statements 196 | ERROR | [ ] Type hint "array" missing for $form 201 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/tests/fixtures/d6_d7_table.php ------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 12 | ERROR | [x] Short array syntax must be used to define arrays 22 | ERROR | [x] Short array syntax must be used to define arrays 64 | ERROR | [x] Short array syntax must be used to define arrays ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/src/Tests/AclTest.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 25 ERRORS AND 1 WARNING AFFECTING 25 LINES --------------------------------------------------------------------------------------------------------------------------------------------------- 26 | ERROR | [ ] Description for the @return value is missing 29 | ERROR | [x] Short array syntax must be used to define arrays 39 | ERROR | [x] Visibility must be declared on method "setUp" 51 | ERROR | [x] Short array syntax must be used to define arrays 56 | ERROR | [x] Doc comment short description must end with a full stop 58 | ERROR | [x] Visibility must be declared on method "testNodeAclCreateDelete" 60 | ERROR | [x] Short array syntax must be used to define arrays 85 | ERROR | [x] Doc comment short description must end with a full stop 85 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 87 | ERROR | [x] Visibility must be declared on method "testNodeAclSingleUserAddRemove" 89 | ERROR | [x] Short array syntax must be used to define arrays 106 | ERROR | [x] No space found before comment text; expected "// $this->drupalLogin($web_user);" but found "//$this->drupalLogin($web_user);" 128 | ERROR | [x] Doc comment short description must end with a full stop 130 | ERROR | [x] Visibility must be declared on method "testNodeAclAddRemoveFromNode" 132 | ERROR | [x] Short array syntax must be used to define arrays 134 | ERROR | [x] Short array syntax must be used to define arrays 136 | ERROR | [x] Short array syntax must be used to define arrays 144 | ERROR | [x] Short array syntax must be used to define arrays 145 | ERROR | [x] Short array syntax must be used to define arrays 152 | WARNING | [ ] Only string literals should be passed to t() where possible 217 | ERROR | [x] Doc comment short description must end with a full stop 219 | ERROR | [ ] Invalid function name, expected test_node_acl_add_and_remove_node but found testNodeAclAddAndRemoveNode 223 | ERROR | [x] Doc comment short description must end with a full stop 225 | ERROR | [ ] Invalid function name, expected test_node_acl_add_and_remove_user but found testNodeAclAddAndRemoveUser 231 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 233 | ERROR | [ ] Invalid function name, expected test_node_acl_permission_check but found testNodeAclPermissionCheck --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/src/Tests/Migrate/d6/MigrateAclList68Test.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------------ 6 | WARNING | [x] Unused use statement 7 | WARNING | [x] Unused use statement 8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found; 22 | ERROR | [ ] Missing @var tag in member variable comment 23 | ERROR | [ ] If the line declaring an array spans longer than 80 characters, each element should be broken into its own line ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/src/Plugin/migrate/source/AclTable.php --------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 24 | ERROR | Class property $table_name should use lowerCamel naming without underscores 31 | ERROR | Class property $fields_list should use lowerCamel naming without underscores --------------------------------------------------------------------------------------------------------------------- FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/src/Plugin/migrate/source/AclList.php -------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------------------------------------------- 23 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 24 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 25 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 26 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 27 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 8 -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/src/Plugin/migrate/destination/AclTable.php -------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------------------- 25 | ERROR | [ ] Class property $table_name should use lowerCamel naming without underscores 32 | ERROR | [ ] Class property $fields_list should use lowerCamel naming without underscores 61 | ERROR | [x] Short array syntax must be used to define arrays 64 | ERROR | [x] Short array syntax must be used to define arrays 65 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 75 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: /Library/WebServer/Documents/PfizerProjects/drupal89/modules/contrib/acl/src/Plugin/migrate/destination/AclList.php ------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------- 23 | ERROR | [x] Short array syntax must be used to define arrays 26 | ERROR | [x] Short array syntax must be used to define arrays 27 | ERROR | [x] Short array syntax must be used to define arrays ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- Time: 197ms; Memory: 10MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
3 pass, 4 fail
Comment almost 2 years ago →
🇨🇭Switzerland salvis
Fixed and re-rolled.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
3 pass, 4 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
last update almost 2 years ago
3 pass, 4 fail
Comment almost 2 years ago →
System Message
The last submitted patch, 15: 3158752-15.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
3 pass, 4 fail
Comment almost 2 years ago →
🇨🇭Switzerland salvis
Try again...
Comment almost 2 years ago →
System Message
The last submitted patch, 17: 3158752-16.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
Composer require failure
Comment almost 2 years ago →
🇨🇭Switzerland salvis
Duh...
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
5 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
5 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
last update almost 2 years ago
5 pass
Comment almost 2 years ago →
System Message

salvis → committed f667e2b9 on 8.x-1.x
Issue #3158752 by salvis, Pooja Ganjage, Suresh Prabhu Parkala: PHP 7.4...
Status changed to Fixed almost 2 years ago10:53pm 17 April 2023
Comment almost 2 years ago →
🇨🇭Switzerland salvis
Thanks to all who helped with this.
Comment almost 2 years ago →
🇨🇭Switzerland salvis
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.