- 🇺🇸United States luke.leber Pennsylvania
Hey all,
After reviewing this, I think the problem lies in the install hook -- not the update hook.
/** * Remove google plus configuration. */ function social_media_update_8001() { \Drupal::configFactory()->getEditable('social_media.settings')->clear('google_plus')->save(); } /** * Implements hook_install(). */ function social_media_install() { social_media_update_8001(); <-- Let's just delete this line! }
We probably don't have to call the update hook from within the install hook because the module doesn't ship with default configuration for google plus anymore. In other words, new users installing the module won't have any google_plus config for us to delete :-). This should alleviate the BLT problem without needing to add any additional logic into the mix.
If someone can re-roll this change against 2.0.x, I'd gladly review and merge it in.
Cheers!
- Assigned to bharath-kondeti
- 🇮🇳India bharath-kondeti Hyderabad
I will work on this patch reroll and provide the update.
- last update
over 1 year ago 1 pass - @bharath-kondeti opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:41am 11 May 2023 - last update
over 1 year ago 1 pass - 🇮🇳India bharath-kondeti Hyderabad
Addressed #3 and rerolled the patch for 2.0.x. Please review