- πΊπΈUnited States mark_fullmer Tucson
Setting this to be related to version 2.0.x-dev, where subsequent development is happening; I'm not sure how valuable this would be to have in the 8.x-1.x branch, given D8's EOL, but if important, we could backport it.
- πΊπΈUnited States mark_fullmer Tucson
1. As of π Strip HTML tags when using assertEquals() to compare markup Fixed , assertEquals() strips all HTML markup, so we need to use assertSame() instead.
2. I replaced file_create_url() with the\Drupal::service('file_url_generator')->generateAbsoluteString
. This appears still to returnhttp://localhost/vfs://root/sites/simpletest/78243062/files/image.jpeg
, however, but I'd like to see this fail on d.o output. The "no_vfs" patch exludes this for comparison purposes but is otherwise the same.
3. I moved one existing procedural helper function into the test class; this might subsequently better go in a test trait?
4. I added a new helper function,runFilter()
, simply for DX benefit so that the individual assertions are easier to read.
5. There's also a fair amount of code syntax standards cleanup. -
dww β
committed df6a3017 on 2.0.x authored by
mark_fullmer β
Issue #3157085 by mark_fullmer: Convert Functional/PathologicTest.php to...
-
dww β
committed df6a3017 on 2.0.x authored by
mark_fullmer β
-
dww β
committed 1334b254 on 8.x-1.x authored by
mark_fullmer β
Issue #3157085 by mark_fullmer: Convert Functional/PathologicTest.php to...
-
dww β
committed 1334b254 on 8.x-1.x authored by
mark_fullmer β
- Status changed to Fixed
over 1 year ago 10:18pm 18 May 2023 - πΊπΈUnited States dww
Fabulous, thanks!
- Committed #2 as its own commit.
- Committed #4 as you for separate history.
- Added another commit to remove the bogus usage of
t()
for the test assertion messages. - Tested on 2.0.x.
- Cherry-picked the 3 commits to 8.x-1.x and tested.
- Pushed all commits to both branches.
Calling this fixed. Thanks again!
-Derek Automatically closed - issue fixed for 2 weeks with no activity.