- Status changed to Fixed
about 2 years ago 7:14am 21 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.
// This may not work. The MTA may rewrite the Return-Path.
if (!isset($headers['Return-Path']) || $headers['Return-Path'] == $default_from) {
if (preg_match('/[a-z\d\-\.\+_]+@(?:[a-z\d\-]+\.)+[a-z\d]{2,4}/i', $from, $matches)) {
$headers['Return-Path'] = "<$matches[0]>";
}
}What's this regular expression supposed to do? If it's just to extract the user@domain part of the $from string, then we should use our 'helper' function mimeMailAddress() which already has a full test suite to prove it works, rather than relying on an untested regular expression.
// This may not work. The MTA may rewrite the Return-Path.
if (!isset($headers['Return-Path']) || $headers['Return-Path'] == $default_from) {
$headers['Return-Path'] = '<' . static::mimeMailAddress($from, TRUE) . '>';
}Another advantage is that mimeMailAddress() is documented so we know what it's supposed to do, unlike the regular expression.
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Automatically closed - issue fixed for 2 weeks with no activity.