Move 'Closed text' to Comment column if enabled

Created on 18 June 2020, over 4 years ago
Updated 31 January 2024, 12 months ago

When having a table/text formatter with closed days and empty days with comment, Both the 'Closed' word and the comments are in different columns.
Move the Closed word to the Comment column if Comments are enabled.

DayTime slotComment
Sunday - Monday:	Closed	<td class="office-hours__item-slots">Closed</td>
Tuesday:		gesloten           <td class="office-hours__item-comments">gesloten</td>
Wednesday - Saturday:	Closed	
Feature request
Status

Needs review

Version

1.0

Component

Code - formatter

Created by

🇳🇱Netherlands johnv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 12 months ago
    Patch Failed to Apply
  • 🇳🇱Netherlands johnv

    Thanks, sorry for the delay.

    Attached patch takes another approach, using php, not twig.
    I am not sure about the wanted behaviour of if ($formatted_slot || $item_comments) {
    Also not sure about the benefits of the change.

    Curious for user feedback.

Production build 0.71.5 2024