Contrib.social

Remove deprecated code and declare Drupal 9 compatibility

Open on Drupal.org →
Created on 18 June 2020, over 4 years ago
Updated 24 February 2023, almost 2 years ago

Problem/Motivation

There's still at least some deprecated code in this module, and the .info.yml file only uses core: 8.x (not core_version_requirement).

For example, a very trivial PHPUnit load test for #3152293: [META] Add test coverage for Entity Group Field → fails with:

  1x: Support for using 'type' => 'hidden' in a component is deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use 'region' => 'hidden' instead. See https://www.drupal.org/node/2801513
    1x in LoadTest::testLoad from Drupal\Tests\entitygroupfield\Functional

Proposed resolution

  • Remove deprecated code.
  • Declare D9 compatibility.

Remaining tasks

  1. Flesh out test coverage at #3152293: [META] Add test coverage for Entity Group Field → and children to be more sure we're hitting all the code paths.
  2. Make sure the tests don't uncover any deprecation notices.
  3. Change the .info.yml file to say this works with D9.
  4. Install it on a 9.0.x test site and re-run all the tests.
  5. If we're really happy, commit the .info.yml change.
  6. Update the project node's D9 porting field.

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States dww

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024