Review if the commerce_exchanger should be required by the currency resolver module

Created on 9 June 2020, over 4 years ago
Updated 18 November 2024, 4 days ago

I want to have the "currency source" set to "Price field per currency". My understanding is that I don't need any kind exchange rate process in that case. However, it is a mandatory field and hence I can't submit the form without selecting an option.
Also, the Exchange Rate API field is empty so it is actually not even possible to select a default option to submit the form.

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇫🇷France vbouchet

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • We have added the patch in the commerce exchanger module. https://www.drupal.org/project/commerce_exchanger/issues/3177803#comment... Don't convert the price if the exchanger is not enabled Closed: works as designed

    To make that work, the below patch needs to be added in commerce_currency_resolver. Otherwise, we will get the below error,

    Fatal error: Class Drupal\commerce_currency_resolver\PriceExchangerCalculator contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\commerce_exchanger\ExchangerCalculatorInterface::exchangerIsEnabled) in /var/www/html/web/modules/contrib/commerce_currency_resolver/src/PriceExchangerCalculator.php on line 12

Production build 0.71.5 2024